Subzero: For filetype=asm, don't print a blank line for pseudo instrs.

Subzero: For filetype=asm, don't print a blank line for pseudo instrs.

Originally, for each non-deleted instruction, CfgNode::emit() would call the virtual Inst::emit() and then print a newline (also printing end-of-live-range info as necessary).  This resulted in clumsy blank lines in the asm output, corresponding to non target specific pseudo instructions such as FakeDef, FakeUse, FakeKill.

We change this so that CfgNode::emit() only prints a newline for an InstTarget subclass, or if any end-of-live-range text was printed.

If a high-level instruction still wants to emit something in a comment, it's responsible for printing its own newline.

BUG= none
TEST= ./pydir/szbuild_spec2k.py -O2 --force -v --filetype=asm --sz=--asm-verbose=0
TEST= ./pydir/szbuild_spec2k.py -O2 --force -v --filetype=asm --sz=--asm-verbose=1
TEST= ./pydir/szbuild_spec2k.py -O2 --force -v --filetype=asm --target=arm32
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3e859b730520288ace79f10c3e8064dd9dcfe6d0

[Jim Stichnoth, 2015-11-10 22:29:36]

Description was changed from

==========
Subzero: For filetype=asm, don't print a blank line for pseudo instrs.

BUG= none
==========

to

==========
Subzero: For filetype=asm, don't print a blank line for pseudo instrs.

Originally, for each non-deleted instruction, CfgNode::emit() would call the
virtual Inst::emit() and then print a newline (also printing end-of-live-range
info as necessary).  This resulted in clumsy blank lines in the asm output,
corresponding to non target specific pseudo instructions such as FakeDef,
FakeUse, FakeKill.

We change this so that CfgNode::emit() only prints a newline for an InstTarget
subclass, or if any end-of-live-range text was printed.

If a high-level instruction still wants to emit something in a comment, it's
responsible for printing its own newline.

BUG= none
TEST= ./pydir/szbuild_spec2k.py -O2 --force -v --filetype=asm
--sz=--asm-verbose=0
TEST= ./pydir/szbuild_spec2k.py -O2 --force -v --filetype=asm
--sz=--asm-verbose=1
TEST= ./pydir/szbuild_spec2k.py -O2 --force -v --filetype=asm --target=arm32
==========

[Jim Stichnoth, 2015-11-10 22:29:36]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Karl, 2015-11-10 22:34:34]

lgtm

[Jim Stichnoth, 2015-11-10 22:39:54]

Committed patchset #1 (id:1) manually as
3e859b730520288ace79f10c3e8064dd9dcfe6d0 (presubmit successful).