Issue 1431313005: Fix invalid cast in CXFA_FFNotify::OnLayoutItemRemoving().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1431313005: Fix invalid cast in CXFA_FFNotify::OnLayoutItemRemoving(). (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Fix invalid cast in CXFA_FFNotify::OnLayoutItemRemoving(). There's a re-interpretation followed by a pointer-adjusting static cast required here, not just a blatant re-interpretation. BUG=pdfium:271 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ad928700bf2dac99148b12f0848fcfab6746ce26

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	xfa/src/fxfa/src/app/xfa_ffnotify.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 1 month ago (2015-11-10 22:36:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ad928700bf2dac99148b12f0848fcfab6746ce26 (presubmit successful).