Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: runtime/bin/main.cc

Issue 14313002: Added ctrl-\ support in dart binary to dump isolate stacks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/bin.gypi ('k') | runtime/bin/vmstats_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
===================================================================
--- runtime/bin/main.cc (revision 21590)
+++ runtime/bin/main.cc (working copy)
@@ -49,7 +49,7 @@
// Global state that defines the VmStats web server port and root directory.
static int vmstats_port = -1;
-static const char* vmstats_root = NULL;
+static const char* vmstats_root = "";
// Value of the --package-root flag.
// (This pointer points into an argv buffer and does not need to be
@@ -733,6 +733,7 @@
Log::Print("Debugger initialized\n");
}
}
+ VmStats::Start(vmstats_port, vmstats_root, verbose_debug_seen);
// Call CreateIsolateAndSetup which creates an isolate and loads up
// the specified application script.
@@ -757,10 +758,6 @@
Dart_EnterScope();
- if (vmstats_port >= 0) {
- VmStats::Start(vmstats_port, vmstats_root);
- }
-
if (generate_script_snapshot) {
// First create a snapshot.
Dart_Handle result;
@@ -821,6 +818,7 @@
if (Dart_IsError(result)) {
return ErrorExit("%s\n", Dart_GetError(result));
}
+
// Keep handling messages until the last active receive port is closed.
result = Dart_RunLoop();
if (Dart_IsError(result)) {
« no previous file with comments | « runtime/bin/bin.gypi ('k') | runtime/bin/vmstats_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698