content/child/blink_platform_impl.cc - Issue 1431233002: Remove blink's use of RC4 for random value generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/blink_platform_impl.cc

Issue 1431233002: Remove blink's use of RC4 for random value generation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@random_asserts

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/html_viewer/blink_platform_impl.cc ('k') | third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.cpp » ('j') | third_party/WebKit/Source/wtf/CryptographicallyRandomNumber.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/blink_platform_impl.cc

diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc

index c885851418ffe27144337e4cc6beb8e925b8ebc8..6c241bb83c117c3ba6fa515b76dd2d8d7d3cc7af 100644

--- a/content/child/blink_platform_impl.cc

+++ b/content/child/blink_platform_impl.cc

@@ -17,7 +17,6 @@

#include "base/metrics/histogram.h"

#include "base/metrics/sparse_histogram.h"

#include "base/process/process_metrics.h"

-#include "base/rand_util.h"

#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

@@ -58,6 +57,7 @@

#include "content/child/websocket_bridge.h"

#include "content/child/worker_task_runner.h"

#include "content/public/common/content_client.h"

+#include "crypto/random.h"

#include "net/base/data_url.h"

#include "net/base/ip_address_number.h"

#include "net/base/net_errors.h"

@@ -1089,7 +1089,7 @@ double BlinkPlatformImpl::systemTraceTime() {

void BlinkPlatformImpl::cryptographicallyRandomValues(

unsigned char* buffer, size_t length) {

- base::RandBytes(buffer, length);

+ crypto::RandBytes(buffer, length);

}

blink::WebGestureCurve* BlinkPlatformImpl::createFlingAnimationCurve(