Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: mojo/edk/embedder/platform_channel_pair.h

Issue 1431203002: EDK: Make PlatformChannelPair not depend/use on base::CommandLine. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/embedder/platform_channel_pair.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/embedder/platform_channel_pair.h
diff --git a/mojo/edk/embedder/platform_channel_pair.h b/mojo/edk/embedder/platform_channel_pair.h
index 8e1771aedd881b88273ed5877c75445216a3d597..3e3c341e09c5a82c66463334e8c59763b4cba96a 100644
--- a/mojo/edk/embedder/platform_channel_pair.h
+++ b/mojo/edk/embedder/platform_channel_pair.h
@@ -5,14 +5,12 @@
#ifndef MOJO_EDK_EMBEDDER_PLATFORM_CHANNEL_PAIR_H_
#define MOJO_EDK_EMBEDDER_PLATFORM_CHANNEL_PAIR_H_
+#include <string>
+
#include "base/process/launch.h"
#include "mojo/edk/embedder/scoped_platform_handle.h"
#include "mojo/public/cpp/system/macros.h"
-namespace base {
-class CommandLine;
-}
-
namespace mojo {
namespace embedder {
@@ -53,15 +51,19 @@ class PlatformChannelPair {
// To be called in the child process, after the parent process called
// |PrepareToPassClientHandleToChildProcess()| and launched the child (using
// the provided data), to create a client handle connected to the server
- // handle (in the parent process).
+ // handle (in the parent process). |string_from_parent| should be the string
+ // that was produced (in the parent process) by
+ // |PrepareToPassClientHandleToChildProcess()|.
static ScopedPlatformHandle PassClientHandleFromParentProcess(
- const base::CommandLine& command_line);
+ const std::string& string_from_parent);
// Prepares to pass the client channel to a new child process, to be launched
- // using |LaunchProcess()| (from base/launch.h). Modifies |*command_line| and
- // |*handle_passing_info| as needed.
+ // using |LaunchProcess()| (from base/launch.h). |*string_for_child| will be
+ // set to a string that should be passed to the child process and which should
+ // be given (in the child ) to |PassClientHandleFromParentProcess()|. Also
+ // modifies |*handle_passing_info| as needed.
void PrepareToPassClientHandleToChildProcess(
- base::CommandLine* command_line,
+ std::string* string_for_child,
HandlePassingInformation* handle_passing_info) const;
// To be called once the child process has been successfully launched, to do
« no previous file with comments | « no previous file | mojo/edk/embedder/platform_channel_pair.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698