Issue 1431203002: EDK: Make PlatformChannelPair not depend/use on base::CommandLine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1431203002: EDK: Make PlatformChannelPair not depend/use on base::CommandLine. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Make PlatformChannelPair not depend/use on base::CommandLine. (Now it doesn't need to use any command line class at all.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9f743d98ddd4e6803a1f1718277b7aec60af4559

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -36 lines)			Patch
M	mojo/edk/embedder/platform_channel_pair.h	View	2 chunks	+11 lines, -9 lines	0 comments	Download
M	mojo/edk/embedder/platform_channel_pair.cc	View	4 chunks	+6 lines, -21 lines	0 comments	Download
M	mojo/edk/test/multiprocess_test_helper.cc	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	shell/child_main.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	shell/child_process_host.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	shell/child_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	shell/child_switches.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm calling the thing 'string' is a little sad but I guess it doesn't really ...

5 years, 1 month ago (2015-11-09 21:01:50 UTC) #2

viettrungluu

5 years, 1 month ago (2015-11-09 21:13:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f743d98ddd4e6803a1f1718277b7aec60af4559 (presubmit successful).

Expand Messages | Collapse Messages