Issue 14312009: drive: Add a very basic browser test for the autocomplete feature

Issue 14312009: drive: Add a very basic browser test for the autocomplete feature (Closed)

Created:
7 years, 8 months ago by satorux1

Modified:
7 years, 8 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Add a very basic browser test for the autocomplete feature The test verifies that the autocomplete list is shown properly. BUG=179976 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194730

Patch Set 1 : #

Total comments: 5

Patch Set 2 : address comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -0 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/test_util.js	View	1	2 chunks	+58 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mtomasz

lgtm with nits. https://codereview.chromium.org/14312009/diff/2001/chrome/browser/resources/file_manager/js/test_util.js File chrome/browser/resources/file_manager/js/test_util.js (right): https://codereview.chromium.org/14312009/diff/2001/chrome/browser/resources/file_manager/js/test_util.js#newcode128 chrome/browser/resources/file_manager/js/test_util.js:128: * Performs autocomplete with the given ...

7 years, 8 months ago (2013-04-17 07:51:10 UTC) #2

satorux1

Thank you for the helpful suggestions. https://codereview.chromium.org/14312009/diff/2001/chrome/browser/resources/file_manager/js/test_util.js File chrome/browser/resources/file_manager/js/test_util.js (right): https://codereview.chromium.org/14312009/diff/2001/chrome/browser/resources/file_manager/js/test_util.js#newcode128 chrome/browser/resources/file_manager/js/test_util.js:128: * Performs autocomplete ...

7 years, 8 months ago (2013-04-17 08:03:31 UTC) #3

satorux1

7 years, 8 months ago (2013-04-18 00:06:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194730 (presubmit successful).

Expand Messages | Collapse Messages