Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 14312007: Don't release capture when this window doesn't already have it (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Don't release capture when this window doesn't already have it - frame called ::SetCapture - mouse down on menu button - menu opens and calls ::SetCapture - Windows notifies frame that it's lost capture - The DesktopCaptureClient release its internal capture state, but also releases native capture - which releases the menu's capture, not its capture. This makes sure that the window that's releasing capture is really the one that has it. R=ben@chromium.org BUG=232155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
7 years, 8 months ago (2013-04-17 04:28:49 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-17 20:08:54 UTC) #2
scottmg
7 years, 8 months ago (2013-04-17 21:18:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698