Issue 14312006: Generate autofill messages inside the component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14312006: Generate autofill messages inside the component (Closed)

Created:
7 years, 8 months ago by kaiwang

Modified:
7 years, 8 months ago

Reviewers:
Ilya Sherman, Ben Goodger (Google), Jói

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Generate autofill messages inside the component BUG=140037 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194667

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	chrome/common/common_message_generator.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/autofill.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	components/autofill/common/autofill_message_generator.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	components/autofill/common/autofill_message_generator.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	components/autofill/common/autofill_messages.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r194667.

Expand Messages | Collapse Messages