[Chromecast] Adds Browser test for media playback

[Chromecast] Adds Browser test for media playback

This is the best mechanism I can find for testing overlay video frame
creation and usage (something which can easily be broken right now).
It also makes up for the recent loss of the cma end to end test.

The overlay frames are still broken (fixing in a separate CL), so this
includes a couple of tweaks to handle the breakage more gracefully and
fall back to black frames.  Once overlays are fixed, that can be
replaced with some stronger assertions.

BUG=internal b/25230251

Committed: https://crrev.com/7c3a5f4bd5583a7be9cd8064c8a0323cbc95ad33
Cr-Commit-Position: refs/heads/master@{#359191}

[halliwell, 2015-11-10 21:25:21]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[halliwell, 2015-11-10 21:26:08]

Description was changed from

==========
[Chromecast] Adds Browser test for media playback

This is the best mechanism I can find for testing overlay video frame
creation and usage (something which can easily be broken right now).
It also makes up for the recent loss of the cma end to end test.

The overlay frames are still broken (fixing in a separate CL), so this
includes a couple of tweaks to handle the breakage more gracefully and
fall back to black frames.  Once overlays are fixed, that can be
replaced with some stronger assertions.

BUG=internal b/25230251
==========

to

==========
[Chromecast] Adds Browser test for media playback

This is the best mechanism I can find for testing overlay video frame
creation and usage (something which can easily be broken right now).
It also makes up for the recent loss of the cma end to end test.

The overlay frames are still broken (fixing in a separate CL), so this
includes a couple of tweaks to handle the breakage more gracefully and
fall back to black frames.  Once overlays are fixed, that can be
replaced with some stronger assertions.

BUG=internal b/25230251
==========

[halliwell, 2015-11-10 21:26:08]

halliwell@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, servolk@chromium.org, slan@chromium.org

[commit-bot: I haz the power, 2015-11-10 21:26:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431193005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431193005/140001

[halliwell, 2015-11-10 21:26:51]

@phajdan.jr: testing/buildbot
@slan: gn changes

[commit-bot: I haz the power, 2015-11-10 22:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 22:41:20]

Dry run: This issue passed the CQ dry run.

[slan, 2015-11-10 23:02:11]

GN lgtm + nits

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_browser_test.cc (right):

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:43:
RunMediaTestPage("player.html", query_params, kEnded);
nit: const in anon namespace

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:60: VLOG(0) << "Running
test URL: " << gurl;
nit: LOG(INFO) or remove.

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:83:
PlayVideo("bear.mp4");
nit const in anon namespace

[halliwell, 2015-11-11 17:22:40]

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_browser_test.cc (right):

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:43:
RunMediaTestPage("player.html", query_params, kEnded);
On 2015/11/10 23:02:11, slan wrote:
> nit: const in anon namespace

I disagree: the point of such constants is to create a single point for changing
things that are used in more than 1 place.  In this case, it would just make you
have to jump around when reading/updating code.

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:60: VLOG(0) << "Running
test URL: " << gurl;
On 2015/11/10 23:02:11, slan wrote:
> nit: LOG(INFO) or remove.

removed.

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:83:
PlayVideo("bear.mp4");
On 2015/11/10 23:02:11, slan wrote:
> nit const in anon namespace

disagree as above.

[halliwell, 2015-11-11 17:42:02]

halliwell@chromium.org changed reviewers:
+ dpranke@chromium.org
- phajdan.jr@chromium.org

[halliwell, 2015-11-11 17:42:20]

dpranke: ptal testing/buildbot change

[slan, 2015-11-11 17:46:22]

lgtm

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_browser_test.cc (right):

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:43:
RunMediaTestPage("player.html", query_params, kEnded);
On 2015/11/11 17:22:40, halliwell wrote:
> On 2015/11/10 23:02:11, slan wrote:
> > nit: const in anon namespace
> 
> I disagree: the point of such constants is to create a single point for
changing
> things that are used in more than 1 place.  In this case, it would just make
you
> have to jump around when reading/updating code.

Agreed, thanks.

https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:83:
PlayVideo("bear.mp4");
On 2015/11/11 17:22:40, halliwell wrote:
> On 2015/11/10 23:02:11, slan wrote:
> > nit const in anon namespace
> 
> disagree as above.

Acknowledged.

[servolk, 2015-11-11 18:11:16]

On 2015/11/11 17:46:22, slan wrote:
> lgtm
> 
>
https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
> File chromecast/browser/test/chromecast_shell_browser_test.cc (right):
> 
>
https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
> chromecast/browser/test/chromecast_shell_browser_test.cc:43:
> RunMediaTestPage("player.html", query_params, kEnded);
> On 2015/11/11 17:22:40, halliwell wrote:
> > On 2015/11/10 23:02:11, slan wrote:
> > > nit: const in anon namespace
> > 
> > I disagree: the point of such constants is to create a single point for
> changing
> > things that are used in more than 1 place.  In this case, it would just make
> you
> > have to jump around when reading/updating code.
> 
> Agreed, thanks.
> 
>
https://codereview.chromium.org/1431193005/diff/140001/chromecast/browser/tes...
> chromecast/browser/test/chromecast_shell_browser_test.cc:83:
> PlayVideo("bear.mp4");
> On 2015/11/11 17:22:40, halliwell wrote:
> > On 2015/11/10 23:02:11, slan wrote:
> > > nit const in anon namespace
> > 
> > disagree as above.
> 
> Acknowledged.

lgtm

[servolk, 2015-11-11 18:11:23]

https://codereview.chromium.org/1431193005/diff/160001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_browser_test.cc (right):

https://codereview.chromium.org/1431193005/diff/160001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:20: 
Nit: redundant empty line

[Dirk Pranke, 2015-11-11 18:14:29]

//testing changes lgtm

[halliwell, 2015-11-11 18:40:21]

https://codereview.chromium.org/1431193005/diff/160001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_browser_test.cc (right):

https://codereview.chromium.org/1431193005/diff/160001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_browser_test.cc:20: 
On 2015/11/11 18:11:23, servolk wrote:
> Nit: redundant empty line

Done.

[halliwell, 2015-11-11 18:40:28]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2015-11-11 18:40:28]

The patchset sent to the CQ was uploaded after l-g-t-m from slan@chromium.org,
servolk@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1431193005/#ps180001
(title: "nit rm blank line")

[commit-bot: I haz the power, 2015-11-11 18:41:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431193005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431193005/180001

[commit-bot: I haz the power, 2015-11-11 18:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 18:48:16]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[halliwell, 2015-11-11 22:35:40]

The CQ bit was checked by halliwell@chromium.org

[commit-bot: I haz the power, 2015-11-11 22:40:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431193005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431193005/180001

[commit-bot: I haz the power, 2015-11-12 00:19:34]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-11-12 20:02:00]

Patchset 10 (id:??) landed as
https://crrev.com/7c3a5f4bd5583a7be9cd8064c8a0323cbc95ad33
Cr-Commit-Position: refs/heads/master@{#359191}