Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1431193004: Reland of Make LayoutImageResource::image() parameter explicit (Closed)

Created:
5 years, 1 month ago by davve
Modified:
5 years, 1 month ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make LayoutImageResource::image() parameter explicit (patchset #1 id:1 of https://codereview.chromium.org/1431973002/ ) Reason for revert: Revert the revert. It looks like "Enable slimming paint synchronized painting" was the culprit this time. Relanding. Original issue's description: > Revert of Make LayoutImageResource::image() parameter explicit (patchset #2 id:20001 of https://codereview.chromium.org/1411693006/ ) > > Reason for revert: > Seems to have caused 553045 > > Original issue's description: > > Make LayoutImageResource::image() parameter explicit > > > > It makes the code more explicit and easier to read. No functional > > change expected. > > > > BUG=551419 > > > > Committed: https://crrev.com/3059b983258e55aeacef6e0b04bdd35a72436d3b > > Cr-Commit-Position: refs/heads/master@{#358287} > > TBR=fs@opera.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=551419 > > Committed: https://crrev.com/20fa2832b2650a8654bfd8226561046760ebbfc9 > Cr-Commit-Position: refs/heads/master@{#358551} TBR=fs@opera.com BUG=551419 Committed: https://crrev.com/3360980d098064ddd9f0d6fc01fab1df7f60a7ba Cr-Commit-Position: refs/heads/master@{#358818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
davve
Created Reland of Make LayoutImageResource::image() parameter explicit
5 years, 1 month ago (2015-11-10 07:24:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431193004/1
5 years, 1 month ago (2015-11-10 07:27:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 10:26:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431193004/1
5 years, 1 month ago (2015-11-10 11:01:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 11:06:02 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 11:07:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3360980d098064ddd9f0d6fc01fab1df7f60a7ba
Cr-Commit-Position: refs/heads/master@{#358818}

Powered by Google App Engine
This is Rietveld 408576698