Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2912)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1431193003: Add runtime flag for choosing WMPI or WMPA. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Order. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | media/base/media_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 5a9da313bc67b3f7b2932be454a43784b50d4c8b..60cfde2cfb55ca53055b83104d205d5fe8f0f033 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -116,6 +116,7 @@
#include "gin/modules/module_registry.h"
#include "media/base/audio_renderer_mixer_input.h"
#include "media/base/media_log.h"
+#include "media/base/media_switches.h"
#include "media/blink/webencryptedmediaclient_impl.h"
#include "media/blink/webmediaplayer_impl.h"
#include "media/renderers/gpu_video_accelerator_factories.h"
@@ -2176,6 +2177,13 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
#if defined(OS_ANDROID) && !defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
return CreateAndroidWebMediaPlayer(client, encrypted_client, params);
#else
+#if defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
no sievers 2015/11/09 21:32:35 the combination of compile time switch and runtime
DaleCurtis 2015/11/09 21:50:48 Yeah, hopefully it won't live much longer, the pro
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableUnifiedMediaPipeline)) {
+ return CreateAndroidWebMediaPlayer(client, encrypted_client, params);
+ }
+#endif // defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
+
#if defined(ENABLE_MOJO_MEDIA) && !defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
scoped_ptr<media::RendererFactory> media_renderer_factory(
new media::MojoRendererFactory(GetMediaServiceFactory()));
@@ -2190,7 +2198,7 @@ blink::WebMediaPlayer* RenderFrameImpl::createMediaPlayer(
*render_thread->GetAudioHardwareConfig()));
}
#endif // defined(ENABLE_MOJO_MEDIA) &&
- // !defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
+ // !defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
return new media::WebMediaPlayerImpl(
frame, client, encrypted_client, weak_factory_.GetWeakPtr(),
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | media/base/media_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698