Add runtime flag for choosing WMPI or WMPA.

Add runtime flag for choosing WMPI or WMPA.

Adds a new switch, --enable-unified-media-pipeline to
control usage of WMPI vs WMPA.  Will be needed for finch
experiments as well as local testing.

BUG=507834
TEST=builds, command line flag works

Committed: https://crrev.com/2935ca1f9d285939c1ac7a27dbb52975375c4f7c
Cr-Commit-Position: refs/heads/master@{#358695}

[DaleCurtis, 2015-11-09 21:04:27]

dalecurtis@chromium.org changed reviewers:
+ watk@chromium.org

[DaleCurtis, 2015-11-09 21:04:56]

Description was changed from

==========
Add runtime flag for choosing WMPI or WMPA.

Will be needed for finch experiments as well as local testing.

BUG=507834
TEST=builds, command line flag works
==========

to

==========
Add runtime flag for choosing WMPI or WMPA.

Adds a new switch, --enable-unified-media-pipeline to
control usage of WMPI vs WMPA.  Will be needed for finch
experiments as well as local testing.

BUG=507834
TEST=builds, command line flag works
==========

[watk, 2015-11-09 21:07:38]

lgtm

https://codereview.chromium.org/1431193003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1431193003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:1456:
switches::kEnableUnifiedMediaPipeline,
Alphabetical order? Looks like the other ones are ordered within the #if blocks

[watk, 2015-11-09 21:07:38]

lgtm

https://codereview.chromium.org/1431193003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1431193003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:1456:
switches::kEnableUnifiedMediaPipeline,
Alphabetical order? Looks like the other ones are ordered within the #if blocks

[DaleCurtis, 2015-11-09 21:16:35]

dalecurtis@chromium.org changed reviewers:
+ sievers@chromium.org

[DaleCurtis, 2015-11-09 21:16:36]

+sievers for content/ approval

https://codereview.chromium.org/1431193003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1431193003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:1456:
switches::kEnableUnifiedMediaPipeline,
On 2015/11/09 21:07:38, watk wrote:
> Alphabetical order? Looks like the other ones are ordered within the #if
blocks

Done.

[no sievers, 2015-11-09 21:32:35]

lgtm

https://codereview.chromium.org/1431193003/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1431193003/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:2180: #if
defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
the combination of compile time switch and runtime switch is confusing :x

[DaleCurtis, 2015-11-09 21:50:48]

Thanks for reviews!

https://codereview.chromium.org/1431193003/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1431193003/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:2180: #if
defined(ENABLE_MEDIA_PIPELINE_ON_ANDROID)
On 2015/11/09 21:32:35, sievers wrote:
> the combination of compile time switch and runtime switch is confusing :x

Yeah, hopefully it won't live much longer, the problem is the compile flags add
a fair bit of apk size, so we're waiting until we know we can play EME/premium
content on this path and we have all the fallback mechanisms in place before
committing to it.

[DaleCurtis, 2015-11-09 21:50:52]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2015-11-09 21:50:53]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org
Link to the patchset: https://codereview.chromium.org/1431193003/#ps20001
(title: "Order.")

[commit-bot: I haz the power, 2015-11-09 21:51:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1431193003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1431193003/20001

[commit-bot: I haz the power, 2015-11-09 23:06:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-09 23:08:02]

Patchset 2 (id:??) landed as
https://crrev.com/2935ca1f9d285939c1ac7a27dbb52975375c4f7c
Cr-Commit-Position: refs/heads/master@{#358695}