Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Side by Side Diff: third_party/protobuf26/README.chromium

Issue 1431173002: Revert of Removed virtualenv from depot_tools (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/cq_client/validate_config.py ('k') | update_depot_tools » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 This directory contains google.protobuf module version 2.6.0 build 0. 1 This directory contains google.protobuf module version 2.6.0 build 0.
2 2
3 sergiyb@: It has been manually renamed to protobuf26. This is needed to avoid 3 sergiyb@: It has been manually renamed to protobuf26. This is needed to avoid
4 conflicts with a built-in google.protobuf module found on many developer 4 conflicts with a built-in google.protobuf module found on many developer
5 machines. The long-term solution to this problem was to use virtualenv and it 5 machines. The long-term solution to this problem, however, should be virtualenv.
6 was implemented, but had to be reverted due to incompatibilities with ChromiumOS 6 Unfortunately due to limited time and lack of experience, it was not a
7 builds (see http://crbug.com/542922). 7 reasonable short-term solution.
8 8
9 If you need to update this package, please make sure that you replace all the 9 If you need to update this package, please make sure that you replace all
10 references to google.protobuf in the package itself with protobuf26, e.g. 10 the references to google.protobuf in the package itself with protobuf26, e.g.
11 11
12 from google.protobuf import text_format 12 from google.protobuf import text_format
13 import google.protobuf 13 import google.protobuf
14 14
15 becomes 15 becomes
16 16
17 from protobuf26 import text_format 17 from protobuf26 import text_format
18 import protobuf26 18 import protobuf26
19 19
20 Original bug tracking setting up virtualenv for depot_tools was 20 Bug tracking setting up virtualenv for depot_tools is https://crbug.com/496241.
21 http://crbug.com/503067, but it was closed as WontFix. If you believe that
22 virtualenv should be added to the current version of depot_tools, please re-open
23 that bug.
OLDNEW
« no previous file with comments | « third_party/cq_client/validate_config.py ('k') | update_depot_tools » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698