Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1431173002: Revert of Removed virtualenv from depot_tools (Closed)

Created:
5 years, 1 month ago by dnj
Modified:
5 years, 1 month ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Removed virtualenv from depot_tools (patchset #1 id:1 of https://codereview.chromium.org/1437483002/ ) Reason for revert: This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this. update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems. I'm reverting to restore the toolchain so we can create new Windows bots. Original issue's description: > Removed virtualenv from depot_tools > > This effectively reverts http://crrev.com/1195423002 and > http://crrev.com/1205873002. > > R=pgervais@chromium.org, tandrii@chromium.org > TBR=pgervais@chromium.org # i wanna get my Fixit credit today :-) > BUG=542922, 503067 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491 TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542922, 503067 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7072 lines, -31 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
A bootstrap/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A bootstrap/bootstrap.py View 1 chunk +234 lines, -0 lines 0 comments Download
A bootstrap/deps.pyl View 1 chunk +15 lines, -0 lines 0 comments Download
A bootstrap/gclient.bat View 1 chunk +22 lines, -0 lines 0 comments Download
A bootstrap/util.py View 1 chunk +87 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/.gitignore View 1 chunk +10 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/.travis.yml View 1 chunk +28 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/AUTHORS.txt View 1 chunk +91 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/CONTRIBUTING.rst View 1 chunk +21 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/LICENSE.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/MANIFEST.in View 1 chunk +11 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/README.rst View 1 chunk +10 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/bin/rebuild-script.py View 1 chunk +71 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/Makefile View 1 chunk +130 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/changes.rst View 1 chunk +747 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/conf.py View 1 chunk +149 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/development.rst View 1 chunk +61 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/index.rst View 1 chunk +137 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/installation.rst View 1 chunk +58 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/make.bat View 1 chunk +170 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/reference.rst View 1 chunk +256 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/docs/userguide.rst View 1 chunk +249 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/scripts/virtualenv View 1 chunk +3 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/setup.py View 1 chunk +111 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A bootstrap/virtualenv/tests/test_activate.sh View 1 chunk +94 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/test_activate_expected.output View 1 chunk +2 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/test_virtualenv.py View 1 chunk +139 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tests/tox.ini View 1 chunk +12 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/tox.ini View 1 chunk +17 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv.py View 1 chunk +2367 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.bat View 1 chunk +26 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.csh View 1 chunk +42 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.fish View 1 chunk +74 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.ps1 View 1 chunk +150 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate.sh View 1 chunk +80 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/activate_this.py View 1 chunk +34 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/deactivate.bat View 1 chunk +20 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/distutils.cfg View 1 chunk +6 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/distutils-init.py View 1 chunk +101 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_embedded/site.py View 1 chunk +758 lines, -0 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_support/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A bootstrap/virtualenv/virtualenv_support/pip-6.0-py2.py3-none-any.whl View Binary file 0 comments Download
A bootstrap/virtualenv/virtualenv_support/setuptools-8.2.1-py2.py3-none-any.whl View Binary file 0 comments Download
A bootstrap/win/README.google View 1 chunk +16 lines, -0 lines 0 comments Download
A bootstrap/win/get_file.js View 1 chunk +119 lines, -0 lines 0 comments Download
A bootstrap/win/pylint.new.bat View 1 chunk +7 lines, -0 lines 0 comments Download
A bootstrap/win/python276.new.bat View 1 chunk +8 lines, -0 lines 0 comments Download
A bootstrap/win/svn.new.bat View 1 chunk +4 lines, -0 lines 0 comments Download
A bootstrap/win/svnversion.new.bat View 1 chunk +4 lines, -0 lines 0 comments Download
A bootstrap/win/unzip.js View 1 chunk +91 lines, -0 lines 0 comments Download
A bootstrap/win/win_tools.bat View 1 chunk +173 lines, -0 lines 0 comments Download
M commit_queue View 1 chunk +5 lines, -1 line 0 comments Download
M commit_queue.bat View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 chunk +5 lines, -13 lines 0 comments Download
M third_party/cq_client/validate_config.py View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/protobuf26/README.chromium View 2 chunks +6 lines, -9 lines 0 comments Download
M update_depot_tools View 1 chunk +4 lines, -0 lines 0 comments Download
M update_depot_tools.bat View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dnj
Created Revert of Removed virtualenv from depot_tools
5 years, 1 month ago (2015-11-09 18:30:00 UTC) #1
dnj
Committed patchset #1 (id:1) manually as 297493 (presubmit successful).
5 years, 1 month ago (2015-11-09 18:49:46 UTC) #2
tandrii(chromium)
5 years, 1 month ago (2015-11-09 18:52:01 UTC) #3
Message was sent while issue was closed.
lgtm, thanks, Dan!

Powered by Google App Engine
This is Rietveld 408576698