Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: mojo/runner/BUILD.gn

Issue 1431133003: mandoline: Reland "Fix ICU initialization". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT and then fix compile. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/public/cpp/initialize_base_and_icu.cc ('k') | mojo/runner/context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/runner/BUILD.gn
diff --git a/mojo/runner/BUILD.gn b/mojo/runner/BUILD.gn
index 803b4ff101d1715d0967ff2207124138eddd6539..84bc12b48d0c3073253c168d1428140d335ba5d6 100644
--- a/mojo/runner/BUILD.gn
+++ b/mojo/runner/BUILD.gn
@@ -52,7 +52,7 @@ source_set("mojo_runner_lib") {
]
deps += [
"//components/tracing:startup_tracing",
- "//mojo/shell",
+ "//third_party/icu:icudata",
]
} else {
sources += [
@@ -106,6 +106,7 @@ source_set("init") {
deps = [
"//mojo/runner/host:switches",
"//base",
+ "//base:i18n",
]
}
@@ -147,6 +148,7 @@ source_set("lib") {
public_deps = [
":init",
":switches",
+ "//mojo/shell",
]
if (!is_component_build) {
@@ -327,10 +329,12 @@ if (is_android) {
deps = [
"//mojo/services/test_service:test_app",
"//mojo/services/test_service:test_request_tracker_app",
+ "//third_party/icu:icudata",
]
# Directories can't be specified as sources so pass manually to the script.
args = [
+ "--files=" + rebase_path("$root_out_dir/icudtl.dat", root_build_dir),
"--files=" + rebase_path("$root_out_dir/test_app", root_build_dir),
"--files=" +
rebase_path("$root_out_dir/test_request_tracker_app", root_build_dir),
« no previous file with comments | « mojo/application/public/cpp/initialize_base_and_icu.cc ('k') | mojo/runner/context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698