mojo/application/public/cpp/BUILD.gn - Issue 1431133003: mandoline: Reland "Fix ICU initialization".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application/public/cpp/BUILD.gn

Issue 1431133003: mandoline: Reland "Fix ICU initialization". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT and then fix compile. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/application/public/cpp/BUILD.gn

diff --git a/mojo/application/public/cpp/BUILD.gn b/mojo/application/public/cpp/BUILD.gn

index 12b0e5197dfc9710e586169ef371a408e5d1f350..578463ff25b590eb12cc01b5c776858538e6add4 100644

--- a/mojo/application/public/cpp/BUILD.gn

+++ b/mojo/application/public/cpp/BUILD.gn

@@ -26,6 +26,7 @@ source_set("sources") {

"application_impl.h",

"application_runner.h",

"connect.h",

+ "initialize_base_and_icu.cc",

"interface_factory.h",

"interface_factory_impl.h",

"lib/app_lifetime_helper.cc",

@@ -44,6 +45,7 @@ source_set("sources") {

deps = [

"//base",

+ "//base:i18n",

"//mojo/application/public/interfaces",

"//mojo/common",

"//mojo/environment:chromium",