Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1431133002: X87: [builtins] Introduce specialized Call/CallFunction builtins. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Introduce specialized Call/CallFunction builtins. port 7c3396d01c7181b22b3dc4cdc38cd4b288f7d9c3 (r31871) original commit message: Introduce receiver conversion mode specialization for the Call and CallFunction builtins, so we can specialize the builtin functionality (actually an optimization only) based on static information from the callsite (this is basically a superset of the optimizations that were available with the CallFunctionStub and CallICStub, except that these optimizations are correct now). This fixes a regression introduced by the removal of CallFunctionStub, for programs that call a lot. BUG= Committed: https://crrev.com/9acf00c78d1bf0e31359e5bac794608da2cbe50c Cr-Commit-Position: refs/heads/master@{#31884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -63 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 8 chunks +12 lines, -6 lines 0 comments Download
M src/x87/builtins-x87.cc View 5 chunks +62 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-09 09:46:56 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-09 13:20:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431133002/1
5 years, 1 month ago (2015-11-09 13:20:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 14:05:40 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 14:06:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9acf00c78d1bf0e31359e5bac794608da2cbe50c
Cr-Commit-Position: refs/heads/master@{#31884}

Powered by Google App Engine
This is Rietveld 408576698