Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1431103005: Avoid truncation to int when setting background-position coordinates (Closed)

Created:
5 years, 1 month ago by davve
Modified:
5 years, 1 month ago
Reviewers:
pdr., fs
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid truncation to int when setting background-position coordinates This error was part of the original https://bugs.webkit.org/show_bug.cgi?id=103440 implementation of background-position but then only for non-repeating backgrounds. When also used for repeating backgrounds through https://codereview.chromium.org/1287293002 it has been noticed that the background-position was sometimes a pixel off when zooming. BUG=535504 Committed: https://crrev.com/25015ec55dfc1a4719c4f7e1c8448dcac6eea9f1 Cr-Commit-Position: refs/heads/master@{#359101}

Patch Set 1 #

Patch Set 2 : Limit test to the bug; background-repeat: no-repeat has further issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/backgrounds/background-position-zoomed.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/backgrounds/background-position-zoomed-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431103005/1
5 years, 1 month ago (2015-11-10 11:19:15 UTC) #2
davve
See, I get to do fun stuff while you're slaving away at BlinkOn. Have a ...
5 years, 1 month ago (2015-11-10 11:20:09 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/132772)
5 years, 1 month ago (2015-11-10 12:11:37 UTC) #6
davve
On 2015/11/10 12:11:37, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years, 1 month ago (2015-11-10 12:47:53 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431103005/20001
5 years, 1 month ago (2015-11-10 14:13:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/128644)
5 years, 1 month ago (2015-11-10 15:31:55 UTC) #11
davve
On 2015/11/10 15:31:55, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years, 1 month ago (2015-11-11 08:39:57 UTC) #12
fs
lgtm
5 years, 1 month ago (2015-11-11 13:40:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431103005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431103005/20001
5 years, 1 month ago (2015-11-11 15:01:42 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-11 16:57:15 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:58:02 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25015ec55dfc1a4719c4f7e1c8448dcac6eea9f1
Cr-Commit-Position: refs/heads/master@{#359101}

Powered by Google App Engine
This is Rietveld 408576698