Chrome Apps Page: Fixed issue with app focusing and context.

chrome/browser/resources/ntp4/tile_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   // We can't pass the currently dragging tile via dataTransfer because of
   // http://crbug.com/31037
   var currentlyDraggingTile = null;
@@ skipping 685 matching lines @@
      * @private
      */
     handleMouseDown_: function(e) {
       var focusable = findAncestorByClass(/** @type {Element} */(e.target),
                                           'focusable');
       if (focusable) {
         this.focusElementIndex_ =
             Array.prototype.indexOf.call(this.focusableElements_,
                                          focusable);
         this.updateFocusElement_();
-      } else {
-        // This prevents the tile page from getting focus when the user clicks
-        // inside the grid but outside of any tile.

[Evan Stade, 2015/11/09 23:29:32]

does this still work? where does focus go if you click between the tiles now

[karandeepb, 2015/11/10 14:23:20]

On clicking between the tiles now, the focus reaches the tile page. This is done
to address the bug https://code.google.com/p/chromium/issues/detail?id=487194

[Evan Stade, 2015/11/11 01:14:57]

honestly, that bug is not worth fixing, but I can't figure out what the purpose
of this block of code is anyway, so it might as well be deleted.

-        e.preventDefault();
       }
-    },
+  },
 
     /**
      * Handle arrow key focus nav.
      * @param {Event} e The focus event.
      * @private
      */
     handleKeyDown_: function(e) {
       // We only handle up, down, left, right without control keys.
       if (e.metaKey || e.shiftKey || e.altKey || e.ctrlKey)
         return;
@@ skipping 656 matching lines @@
   };
 
   return {
     getCurrentlyDraggingTile: getCurrentlyDraggingTile,
     setCurrentDropEffect: setCurrentDropEffect,
     // Not used outside, just for usage in JSDoc inside this file.
     Tile: Tile,
     TilePage: TilePage,
   };
 });