Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1434)

Unified Diff: chrome/browser/chromeos/offline/offline_load_page.cc

Issue 14311003: Fix font on offline load page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/offline/offline_load_page.cc
diff --git a/chrome/browser/chromeos/offline/offline_load_page.cc b/chrome/browser/chromeos/offline/offline_load_page.cc
index a165ede536d662535c206f9a1a66f3a878b04b25..497c3afab90042e4c23ac2fec6f94ae59d1eab7d 100644
--- a/chrome/browser/chromeos/offline/offline_load_page.cc
+++ b/chrome/browser/chromeos/offline/offline_load_page.cc
@@ -99,9 +99,10 @@ std::string OfflineLoadPage::GetHTMLContents() {
// Activation
strings.SetBoolean("show_activation", ShowActivationMessage());
- bool rtl = base::i18n::IsRTL();
- strings.SetString("textdirection", rtl ? "rtl" : "ltr");
+ // Setup our text formatting strings.
Dan Beam 2013/04/17 00:57:01 I don't really understand what this comment adds,
rkc 2013/04/17 19:06:52 Done.
+ webui::SetFontAndTextDirection(&strings);
+ bool rtl = base::i18n::IsRTL();
string16 failed_url(ASCIIToUTF16(url_.spec()));
if (rtl)
Dan Beam 2013/04/17 00:57:01 nit: inline, i.e. if (base::i18n::IsRTL())
rkc 2013/04/17 19:06:52 Done.
base::i18n::WrapStringWithLTRFormatting(&failed_url);

Powered by Google App Engine
This is Rietveld 408576698