Issue 14311003: Fix font on offline load page.

Issue 14311003: Fix font on offline load page. (Closed)

Created:
7 years, 8 months ago by rkc

Modified:
7 years, 8 months ago

Reviewers:
xiyuan, Dan Beam

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix font on offline load page. For some reason, the offline load page is not picking up the default system font but instead defaulting to Times New Roman. This CL fixes it by explicitly setting the font style for the page body. R=dbeam@chromium.org BUG=223934 TEST=Go offline and verify that the font used is the ChromeOS system font. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194685

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/offline/offline_load_page.cc	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
	M	chrome/browser/resources/chromeos/offline_load.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

this should be using the webui font loading mechanism that everywhere else does (set some ...

7 years, 8 months ago (2013-04-16 23:14:34 UTC) #3

Dan Beam

for example: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/resources/plugins.html&l=2,12

7 years, 8 months ago (2013-04-16 23:16:09 UTC) #4

xiyuan

On 2013/04/16 23:14:34, Dan Beam wrote: > this should be using the webui font loading ...

7 years, 8 months ago (2013-04-16 23:19:53 UTC) #5

Dan Beam

On 2013/04/16 23:19:53, xiyuan wrote: > On 2013/04/16 23:14:34, Dan Beam wrote: > > this ...

7 years, 8 months ago (2013-04-16 23:26:48 UTC) #6

Dan Beam

lgtm w/nits (please address first) https://codereview.chromium.org/14311003/diff/8001/chrome/browser/chromeos/offline/offline_load_page.cc File chrome/browser/chromeos/offline/offline_load_page.cc (right): https://codereview.chromium.org/14311003/diff/8001/chrome/browser/chromeos/offline/offline_load_page.cc#newcode102 chrome/browser/chromeos/offline/offline_load_page.cc:102: // Setup our text ...

7 years, 8 months ago (2013-04-17 00:57:01 UTC) #8

rkc

https://codereview.chromium.org/14311003/diff/8001/chrome/browser/chromeos/offline/offline_load_page.cc File chrome/browser/chromeos/offline/offline_load_page.cc (right): https://codereview.chromium.org/14311003/diff/8001/chrome/browser/chromeos/offline/offline_load_page.cc#newcode102 chrome/browser/chromeos/offline/offline_load_page.cc:102: // Setup our text formatting strings. On 2013/04/17 00:57:01, ...

7 years, 8 months ago (2013-04-17 19:06:52 UTC) #9

rkc

7 years, 8 months ago (2013-04-17 21:28:40 UTC) #10

Message was sent while issue was closed.

Committed patchset #5 manually as r194685 (presubmit successful).

Expand Messages | Collapse Messages