Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: net/spdy/spdy_stream.h

Issue 14311002: [SPDY] Avoid leaking bytes from the session flow control receive window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index fd145eadf5c9a5ba75870ba90219c1808e817649..1ae204e6ceb6141920d999e732520d69809f59a1 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -178,16 +178,6 @@ class NET_EXPORT_PRIVATE SpdyStream
// If stream flow control is turned off, this must not be called.
void DecreaseSendWindowSize(int32 delta_window_size);
- // Called by the delegate to increase this stream's receive window
- // size by |delta_window_size|, which must be at least 1 and must
- // not cause this stream's receive window size to overflow, possibly
- // also sending a WINDOW_UPDATE frame.
- //
- // Unlike the functions above, this may be called even when stream
- // flow control is turned off, although this does nothing in that
- // case (and also if the stream is inactive).
- void IncreaseRecvWindowSize(int32 delta_window_size);
-
int GetPeerAddress(IPEndPoint* address) const;
int GetLocalAddress(IPEndPoint* address) const;
@@ -348,6 +338,16 @@ class NET_EXPORT_PRIVATE SpdyStream
scoped_ptr<SpdyFrame> ProduceHeaderFrame(
scoped_ptr<SpdyHeaderBlock> header_block);
+ // Called by SpdyBuffers (via ConsumeCallbacks) to increase this
+ // stream's receive window size by |delta_window_size|, which must
+ // be at least 1 and must not cause this stream's receive window
+ // size to overflow, possibly also sending a WINDOW_UPDATE frame.
+ //
+ // Unlike the functions above, this may be called even when stream
+ // flow control is turned off, although this does nothing in that
+ // case (and also if the stream is inactive).
+ void IncreaseRecvWindowSize(size_t delta_window_size);
+
// If the stream is active and stream flow control is turned on,
// called by OnDataReceived (which is in turn called by the session)
// to decrease this stream's receive window size by
« no previous file with comments | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698