[SPDY] Avoid leaking bytes from the session flow control receive window

net/spdy/spdy_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_STREAM_H_
 #define NET_SPDY_SPDY_STREAM_H_
 
 #include <deque>
 #include <string>
 #include <vector>
@@ skipping 160 matching lines @@
 
   // If stream flow control is turned on, called by the session to
   // decrease this stream's send window size by |delta_window_size|,
   // which must be at least 0 and at most kMaxSpdyFrameChunkSize.
   // |delta_window_size| must not cause this stream's send window size
   // to go negative. Does nothing if the stream is already closed.
   //
   // If stream flow control is turned off, this must not be called.
   void DecreaseSendWindowSize(int32 delta_window_size);
 
-  // Called by the delegate to increase this stream's receive window
-  // size by |delta_window_size|, which must be at least 1 and must
-  // not cause this stream's receive window size to overflow, possibly
-  // also sending a WINDOW_UPDATE frame.
-  //
-  // Unlike the functions above, this may be called even when stream
-  // flow control is turned off, although this does nothing in that
-  // case (and also if the stream is inactive).
-  void IncreaseRecvWindowSize(int32 delta_window_size);
-
   int GetPeerAddress(IPEndPoint* address) const;
   int GetLocalAddress(IPEndPoint* address) const;
 
   // Returns true if the underlying transport socket ever had any reads or
   // writes.
   bool WasEverUsed() const;
 
   const BoundNetLog& net_log() const { return net_log_; }
 
   const SpdyHeaderBlock& spdy_headers() const;
@@ skipping 140 matching lines @@
 
   // Produces the SYN_STREAM frame for the stream. The stream must
   // already be activated.
   scoped_ptr<SpdyFrame> ProduceSynStreamFrame();
 
   // Produce the initial HEADER frame for the stream with the given
   // block. The stream must already be activated.
   scoped_ptr<SpdyFrame> ProduceHeaderFrame(
       scoped_ptr<SpdyHeaderBlock> header_block);
 
+  // Called by SpdyBuffers (via ConsumeCallbacks) to increase this
+  // stream's receive window size by |delta_window_size|, which must
+  // be at least 1 and must not cause this stream's receive window
+  // size to overflow, possibly also sending a WINDOW_UPDATE frame.
+  //
+  // Unlike the functions above, this may be called even when stream
+  // flow control is turned off, although this does nothing in that
+  // case (and also if the stream is inactive).
+  void IncreaseRecvWindowSize(size_t delta_window_size);
+
   // If the stream is active and stream flow control is turned on,
   // called by OnDataReceived (which is in turn called by the session)
   // to decrease this stream's receive window size by
   // |delta_window_size|, which must be at least 1 and must not cause
   // this stream's receive window size to go negative.
   void DecreaseRecvWindowSize(int32 delta_window_size);
 
   base::WeakPtrFactory<SpdyStream> weak_ptr_factory_;
 
   // There is a small period of time between when a server pushed stream is
@@ skipping 62 matching lines @@
   // When OnFrameWriteComplete() is called, these variables are set.
   SpdyFrameType just_completed_frame_type_;
   size_t just_completed_frame_size_;
 
   DISALLOW_COPY_AND_ASSIGN(SpdyStream);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_STREAM_H_