[SPDY] Avoid leaking bytes from the session flow control receive window

net/spdy/spdy_stream_test_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_stream_test_util.h"
 
+#include <cstddef>
+
+#include "base/stl_util.h"
 #include "net/base/completion_callback.h"
 #include "net/spdy/spdy_stream.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace test {
 
 ClosingDelegate::ClosingDelegate(
     const scoped_refptr<SpdyStream>& stream) : stream_(stream) {}
@@ skipping 54 matching lines @@
   EXPECT_TRUE(send_headers_completed_);
   response_ = response;
   return status;
 }
 
 void StreamDelegateBase::OnHeadersSent() {
   headers_sent_++;
 }
 
 int StreamDelegateBase::OnDataReceived(scoped_ptr<SpdyBuffer> buffer) {
-  if (buffer) {
-    received_data_ += std::string(buffer->GetRemainingData(),
-                                  buffer->GetRemainingSize());
-  }
+  if (buffer)
+    received_data_queue_.Enqueue(buffer.Pass());
   return OK;
 }
 
 void StreamDelegateBase::OnDataSent(size_t bytes_sent) {
   data_sent_ += bytes_sent;
 }
 
 void StreamDelegateBase::OnClose(int status) {
   if (!stream_)
     return;
   stream_ = NULL;
   callback_.callback().Run(status);
 }
 
 int StreamDelegateBase::WaitForClose() {
   int result = callback_.WaitForResult();
   EXPECT_TRUE(!stream_.get());
   return result;
 }
 
+std::string StreamDelegateBase::TakeReceivedData() {
+  size_t len = received_data_queue_.GetTotalSize();
+  std::string received_data(len, '\0');
+  if (len > 0) {
+    EXPECT_EQ(
+        len,
+        received_data_queue_.Dequeue(string_as_array(&received_data), len));
+  }
+  return received_data;
+}
+
 std::string StreamDelegateBase::GetResponseHeaderValue(
     const std::string& name) const {
   SpdyHeaderBlock::const_iterator it = response_.find(name);
   return (it == response_.end()) ? std::string() : it->second;
 }
 
 StreamDelegateSendImmediate::StreamDelegateSendImmediate(
     const scoped_refptr<SpdyStream>& stream,
     scoped_ptr<SpdyHeaderBlock> headers,
     base::StringPiece data)
@@ skipping 56 matching lines @@
     // Go back to OnSendBody() to send the remaining data.
     return MORE_DATA_TO_SEND;
   }
 
   return NO_MORE_DATA_TO_SEND;
 }
 
 } // namespace test
 
 } // namespace net