[SPDY] Avoid leaking bytes from the session flow control receive window

net/spdy/spdy_buffer_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_buffer.h"
 
 #include <cstddef>
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/io_buffer.h"
 #include "net/spdy/spdy_protocol.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
 
 namespace {
 
@@ skipping 25 matching lines @@
   std::string data(kData, kDataSize);
   SpdyBuffer buffer(data.data(), data.size());
   // This mutation shouldn't affect |buffer|'s data.
   data[0] = 'H';
 
   EXPECT_NE(kData, buffer.GetRemainingData());
   EXPECT_EQ(kDataSize, buffer.GetRemainingSize());
   EXPECT_EQ(std::string(kData, kDataSize), BufferToString(buffer));
 }
 
+void IncrementBy(size_t* x, size_t delta) {
+  *x += delta;
+}
+
 // Construct a SpdyBuffer and call Consume() on it, which should
-// update the remaining data pointer and size appropriately.
+// update the remaining data pointer and size appropriately, as well
+// as calling the consume callbacks.
 TEST_F(SpdyBufferTest, Consume) {
   SpdyBuffer buffer(kData, kDataSize);
 
+  size_t x1 = 0;
+  size_t x2 = 0;
+  buffer.AddConsumeCallback(base::Bind(&IncrementBy, &x1));
+  buffer.AddConsumeCallback(base::Bind(&IncrementBy, &x2));
+
   EXPECT_EQ(std::string(kData, kDataSize), BufferToString(buffer));
 
   buffer.Consume(5);
   EXPECT_EQ(std::string(kData + 5, kDataSize - 5), BufferToString(buffer));
+  EXPECT_EQ(5u, x1);
+  EXPECT_EQ(5u, x2);
 
   buffer.Consume(kDataSize - 5);
   EXPECT_EQ(0u, buffer.GetRemainingSize());
+  EXPECT_EQ(kDataSize, x1);
+  EXPECT_EQ(kDataSize, x2);
+}
+
+// Construct a SpdyBuffer and attach a ConsumeCallback to it. The
+// callback should be called when the SpdyBuffer is destroyed.
+TEST_F(SpdyBufferTest, ConsumeOnDestruction) {
+  size_t x = 0;
+
+  {
+    SpdyBuffer buffer(kData, kDataSize);
+    buffer.AddConsumeCallback(base::Bind(&IncrementBy, &x));
+  }
+
+  EXPECT_EQ(kDataSize, x);
 }
 
 // Make sure the IOBuffer returned by GetIOBufferForRemainingData()
 // points to the buffer's remaining data and isn't updated by
 // Consume().
 TEST_F(SpdyBufferTest, GetIOBufferForRemainingData) {
   SpdyBuffer buffer(kData, kDataSize);
 
   buffer.Consume(5);
   scoped_refptr<IOBuffer> io_buffer = buffer.GetIOBufferForRemainingData();
   size_t io_buffer_size = buffer.GetRemainingSize();
   const std::string expectedData(kData + 5, kDataSize - 5);
   EXPECT_EQ(expectedData, std::string(io_buffer->data(), io_buffer_size));
 
   buffer.Consume(kDataSize - 5);
   EXPECT_EQ(expectedData, std::string(io_buffer->data(), io_buffer_size));
 }
 
 }  // namespace
 
 }  // namespace net