[SPDY] Avoid leaking bytes from the session flow control receive window

[SPDY] Avoid leaking bytes from the session flow control receive window

Add a way to add ConsumeCallbacks to a SpdyBuffer in order to be notified
when Consume() is called. Use that to ensure that flow control receive
windows are updated appropriately regardless of what the SpdyStream's
delegate does.

Make IncreaseRevWindowSize private in both SpdyStream
and SpdySession.

BUG=176592
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194655

[akalin, 2013-04-16 23:07:38]

+rch for review

[Ryan Hamilton, 2013-04-16 23:41:32]

lgtm

https://codereview.chromium.org/14311002/diff/1/net/spdy/spdy_buffer.cc
File net/spdy/spdy_buffer.cc (right):

https://codereview.chromium.org/14311002/diff/1/net/spdy/spdy_buffer.cc#newco...
net/spdy/spdy_buffer.cc:65: it->Run(consume_size);
Is there any chance that executing one of these callbacks might result in the
buffer being deleted?  You could add a boolean member in_consume_ and
CHECK(!in_consume_) in the destructor.  Is that worth doing?  Alternatively, add
comments about ConsumeCallbacks not being allowed to delete the buffer?

[akalin, 2013-04-16 23:53:10]

Committing as soon as https://codereview.chromium.org/13990005/ lands and the
trybots pass

https://codereview.chromium.org/14311002/diff/1/net/spdy/spdy_buffer.cc
File net/spdy/spdy_buffer.cc (right):

https://codereview.chromium.org/14311002/diff/1/net/spdy/spdy_buffer.cc#newco...
net/spdy/spdy_buffer.cc:65: it->Run(consume_size);
On 2013/04/16 23:41:32, Ryan Hamilton wrote:
> Is there any chance that executing one of these callbacks might result in the
> buffer being deleted?  You could add a boolean member in_consume_ and
> CHECK(!in_consume_) in the destructor.  Is that worth doing?  Alternatively,
add
> comments about ConsumeCallbacks not being allowed to delete the buffer?

I think for the ConsumeCallback's use case, it's better to just add a comment
that ConsumeCallbacks shouldn't cause the buffer to be deleted. Done.

[Ryan Hamilton, 2013-04-17 00:14:32]

https://codereview.chromium.org/14311002/diff/1/net/spdy/spdy_buffer.cc
File net/spdy/spdy_buffer.cc (right):

https://codereview.chromium.org/14311002/diff/1/net/spdy/spdy_buffer.cc#newco...
net/spdy/spdy_buffer.cc:65: it->Run(consume_size);
On 2013/04/16 23:53:10, akalin wrote:
> On 2013/04/16 23:41:32, Ryan Hamilton wrote:
> > Is there any chance that executing one of these callbacks might result in
the
> > buffer being deleted?  You could add a boolean member in_consume_ and
> > CHECK(!in_consume_) in the destructor.  Is that worth doing?  Alternatively,
> add
> > comments about ConsumeCallbacks not being allowed to delete the buffer?
> 
> I think for the ConsumeCallback's use case, it's better to just add a comment
> that ConsumeCallbacks shouldn't cause the buffer to be deleted. Done.

sgtm

[akalin, 2013-04-17 19:23:55]

Committed patchset #3 manually as r194655 (presubmit successful).