|
|
Revert of Move components/startup_metric_utils/* to components/startup_metric_utils/browser/*. (patchset #5 id:80001 of https://codereview.chromium.org/1413153010/ )
Reason for revert:
We suspect that this CL is responsible for a 7.1%-7.7% regression in startup.warm.blank_page (crbug.com/551690)
Original issue's description:
> Move components/startup_metric_utils/* to components/startup_metric_utils/browser/*.
>
> We are working on new startup metrics that require sending IPCs from
> the renderer to the browser. The message definitions will live in
> components/startup_metric_utils/common/*, while the code that receives
> IPCs and logs UMA metrics will live in
> components/startup_metric_utils/browser/*.
>
> As a first step towards implementing these new metrics, this CL moves
> existing code from components/startup_metric_utils/* to
> components/startup_metric_utils/browser/*.
>
> BUG= 547794
>
> Committed: https://crrev.com/055d3862641a91e4a5ff2a49bd5d0f835f0436d1
> Cr-Commit-Position: refs/heads/master@{#357702}
TBR=gab@chromium.org,sky@chromium.org,caitkp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 551690
Committed: https://crrev.com/717f84522681c0810ff444619b40d1bcdabb0079
Cr-Commit-Position: refs/heads/master@{#358278}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+41 lines, -679 lines) |
Patch |
 |
M |
chrome/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/app/DEPS
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/app/android/chrome_main_delegate_android.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/app/chrome_exe_main_win.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/app/chrome_main_delegate.cc
|
View
|
1
|
4 chunks |
+4 lines, -19 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/DEPS
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/chrome_browser_main.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_service.cc
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/first_run/first_run_internal_posix.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/mac/mac_startup_profiler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/metrics/first_web_contents_profiler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/browser.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/simple_message_box_mac.mm
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/startup/bad_flags_prompt.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/startup/default_browser_prompt_win.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/simple_message_box_views.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_exe.gypi
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_renderer.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/renderer/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/bookmarks.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/DEPS
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/html_viewer/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/html_viewer/DEPS
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/html_viewer/stats_collection_controller.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/startup_metric_utils.gypi
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
A + |
components/startup_metric_utils/BUILD.gn
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
components/startup_metric_utils/browser/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
 |
D |
components/startup_metric_utils/browser/startup_metric_utils.h
|
View
|
|
1 chunk |
+0 lines, -107 lines |
0 comments
|
Download
|
 |
D |
components/startup_metric_utils/browser/startup_metric_utils.cc
|
View
|
1
|
1 chunk |
+0 lines, -508 lines |
0 comments
|
Download
|
 |
A + |
components/startup_metric_utils/startup_metric_utils.h
|
View
|
1
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
A + |
components/startup_metric_utils/startup_metric_utils.cc
|
View
|
1
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
Total messages: 14 (6 generated)
|