runtime/vm/stub_code_x64.cc - Issue 1431003002: Short check for zero is tst not cmp...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 1431003002: Short check for zero is tst not cmp... (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_x64.cc

diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc

index ea58adb223aa06383185a7d5e4a2da8c0e55914b..39d8dc96b0b2c7e2d040fa48f1b89270e7cceed6 100644

--- a/runtime/vm/stub_code_x64.cc

+++ b/runtime/vm/stub_code_x64.cc

@@ -2163,8 +2163,8 @@ void StubCode::GenerateICLookupStub(Assembler* assembler) {

__ j(EQUAL, &found, Assembler::kNearJump);

ASSERT(Smi::RawValue(kIllegalCid) == 0);

- __ cmpq(R9, R9);

- __ j(EQUAL, &miss, Assembler::kNearJump);

+ __ testq(R9, R9);

+ __ j(ZERO, &miss, Assembler::kNearJump);

const intptr_t entry_length = ICData::TestEntryLengthFor(1) * kWordSize;

__ addq(R13, Immediate(entry_length)); // Next entry.

« no previous file with comments | « no previous file | no next file » | no next file with comments »