Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1430993003: Add test precompiling dart2js. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M runtime/vm/raw_object_snapshot.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + tests/standalone/precompilation_dart2js_test.dart View 3 chunks +12 lines, -9 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-05 01:35:41 UTC) #2
Florian Schneider
lgtm
5 years, 1 month ago (2015-11-05 02:01:31 UTC) #3
rmacnak
5 years, 1 month ago (2015-11-05 18:43:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
165c21026a230de1531a5aad546ca0372a254f76 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698