Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1430973003: Fix textual emission of label instructions in ARM assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix textual emission of label instructions in ARM assembler. The integrated ARM assembler was incorrectly assuming that an (instruction) label defines a corresponding assembler instruction. Therefore, placement into the buffer was incorrect. This CL fixes this mistake. This fixes assembler translator problems with ARM branch, movw, and movt instructions. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5b004e30f5a54c88075e38a4c4854f3d83ce5e7d

Patch Set 1 #

Patch Set 2 : Remove -unsafe-ias from lit tests that don't need it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M src/IceInstARM32.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M tests_lit/assembler/arm32/branch-simple.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/global-load-store.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/sdiv.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/udiv.ll View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-11-05 16:52:37 UTC) #3
Jim Stichnoth
LGTM. It would also be great if this enables you to remove "-unsafe-ias" from any ...
5 years, 1 month ago (2015-11-06 00:34:39 UTC) #4
Karl
Committed patchset #2 (id:20001) manually as 5b004e30f5a54c88075e38a4c4854f3d83ce5e7d (presubmit successful).
5 years, 1 month ago (2015-11-06 16:52:45 UTC) #5
Karl
5 years, 1 month ago (2015-11-06 16:53:40 UTC) #6
Message was sent while issue was closed.
Removed -unsafe-ias from 4 tests.

Powered by Google App Engine
This is Rietveld 408576698