Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1430943004: [heap] Remove unecessary marking bit check in RecordWriteSlow. (Closed)

Created:
5 years, 1 month ago by Hannes Payer (out of office)
Modified:
5 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unecessary marking bit check in RecordWriteSlow. BUG= Committed: https://crrev.com/45cb28409d4f43b487c012befe7f355ca099ef09 Cr-Commit-Position: refs/heads/master@{#31766}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +2 lines, -5 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/1430943004/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (left): https://codereview.chromium.org/1430943004/diff/1/src/heap/incremental-marking.cc#oldcode82 src/heap/incremental-marking.cc:82: if (BaseRecordWrite(obj, slot, value) && slot != NULL) { ...
5 years, 1 month ago (2015-11-03 22:51:15 UTC) #1
Michael Lippautz
lgtm https://codereview.chromium.org/1430943004/diff/1/src/heap/incremental-marking.cc File src/heap/incremental-marking.cc (left): https://codereview.chromium.org/1430943004/diff/1/src/heap/incremental-marking.cc#oldcode82 src/heap/incremental-marking.cc:82: if (BaseRecordWrite(obj, slot, value) && slot != NULL) ...
5 years, 1 month ago (2015-11-03 22:54:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430943004/1
5 years, 1 month ago (2015-11-04 00:27:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 00:28:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 00:29:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45cb28409d4f43b487c012befe7f355ca099ef09
Cr-Commit-Position: refs/heads/master@{#31766}

Powered by Google App Engine
This is Rietveld 408576698