Chromium Code Reviews| Index: test/cctest/compiler/test-run-machops.cc |
| diff --git a/test/cctest/compiler/test-run-machops.cc b/test/cctest/compiler/test-run-machops.cc |
| index cbea5fec06e6f07b79e8fe623f03fe095e2e77a6..093568f5c937622d7677fc3fd731a32c3376f1d6 100644 |
| --- a/test/cctest/compiler/test-run-machops.cc |
| +++ b/test/cctest/compiler/test-run-machops.cc |
| @@ -3242,7 +3242,10 @@ TEST(RunFloat32Add) { |
| m.Return(m.Float32Add(m.Parameter(0), m.Parameter(1))); |
| FOR_FLOAT32_INPUTS(i) { |
| - FOR_FLOAT32_INPUTS(j) { CheckFloatEq(*i + *j, m.Call(*i, *j)); } |
| + FOR_FLOAT32_INPUTS(j) { |
| + float expected = *i + *j; |
|
titzer
2015/11/03 19:01:43
These should probably be volatile float, as well.
|
| + CheckFloatEq(expected, m.Call(*i, *j)); |
| + } |
| } |
| } |
| @@ -3252,7 +3255,10 @@ TEST(RunFloat32Sub) { |
| m.Return(m.Float32Sub(m.Parameter(0), m.Parameter(1))); |
| FOR_FLOAT32_INPUTS(i) { |
| - FOR_FLOAT32_INPUTS(j) { CheckFloatEq(*i - *j, m.Call(*i, *j)); } |
| + FOR_FLOAT32_INPUTS(j) { |
| + float expected = *i - *j; |
| + CheckFloatEq(expected, m.Call(*i, *j)); |
| + } |
| } |
| } |
| @@ -3262,7 +3268,10 @@ TEST(RunFloat32Mul) { |
| m.Return(m.Float32Mul(m.Parameter(0), m.Parameter(1))); |
| FOR_FLOAT32_INPUTS(i) { |
| - FOR_FLOAT32_INPUTS(j) { CheckFloatEq(*i * *j, m.Call(*i, *j)); } |
| + FOR_FLOAT32_INPUTS(j) { |
| + float expected = *i * *j; |
| + CheckFloatEq(expected, m.Call(*i, *j)); |
| + } |
| } |
| } |
| @@ -3272,7 +3281,10 @@ TEST(RunFloat32Div) { |
| m.Return(m.Float32Div(m.Parameter(0), m.Parameter(1))); |
| FOR_FLOAT32_INPUTS(i) { |
| - FOR_FLOAT32_INPUTS(j) { CheckFloatEq(*i / *j, m.Call(*i, *j)); } |
| + FOR_FLOAT32_INPUTS(j) { |
| + float expected = *i / *j; |
| + CheckFloatEq(expected, m.Call(*i, *j)); |
| + } |
| } |
| } |
| @@ -3302,7 +3314,10 @@ TEST(RunFloat64Mul) { |
| m.Return(m.Float64Mul(m.Parameter(0), m.Parameter(1))); |
| FOR_FLOAT64_INPUTS(i) { |
| - FOR_FLOAT64_INPUTS(j) { CheckDoubleEq(*i * *j, m.Call(*i, *j)); } |
| + FOR_FLOAT64_INPUTS(j) { |
| + double exp = *i * *j; |
| + CheckDoubleEq(exp, m.Call(*i, *j)); |
| + } |
| } |
| } |
| @@ -3312,7 +3327,10 @@ TEST(RunFloat64Div) { |
| m.Return(m.Float64Div(m.Parameter(0), m.Parameter(1))); |
| FOR_FLOAT64_INPUTS(i) { |
| - FOR_FLOAT64_INPUTS(j) { CheckDoubleEq(*i / *j, m.Call(*i, *j)); } |
| + FOR_FLOAT64_INPUTS(j) { |
| + double expected = *i / *j; |
| + CheckDoubleEq(expected, m.Call(*i, *j)); |
| + } |
| } |
| } |
| @@ -3411,7 +3429,10 @@ TEST(RunFloat32SubImm1) { |
| BufferedRawMachineAssemblerTester<float> m(kMachFloat32); |
| m.Return(m.Float32Sub(m.Float32Constant(*i), m.Parameter(0))); |
| - FOR_FLOAT32_INPUTS(j) { CheckFloatEq(*i - *j, m.Call(*j)); } |
| + FOR_FLOAT32_INPUTS(j) { |
| + float expected = *i - *j; |
| + CheckFloatEq(expected, m.Call(*j)); |
| + } |
| } |
| } |
| @@ -3421,7 +3442,10 @@ TEST(RunFloat32SubImm2) { |
| BufferedRawMachineAssemblerTester<float> m(kMachFloat32); |
| m.Return(m.Float32Sub(m.Parameter(0), m.Float32Constant(*i))); |
| - FOR_FLOAT32_INPUTS(j) { CheckFloatEq(*j - *i, m.Call(*j)); } |
| + FOR_FLOAT32_INPUTS(j) { |
| + float expected = *j - *i; |
| + CheckFloatEq(expected, m.Call(*j)); |
| + } |
| } |
| } |