Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: gpu/command_buffer/service/buffer_manager.h

Issue 14308014: Clean up of GLES2 Command Decoder by moving some of the error state into a separate class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix merge error. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/build_gles2_cmd_buffer.py ('k') | gpu/command_buffer/service/buffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/buffer_manager.h
diff --git a/gpu/command_buffer/service/buffer_manager.h b/gpu/command_buffer/service/buffer_manager.h
index ccf2c18fa6b17ce864e9d92777f315706a0e9032..7ccb3f0660b043476fc89b37c334c5ee2ae2b5bf 100644
--- a/gpu/command_buffer/service/buffer_manager.h
+++ b/gpu/command_buffer/service/buffer_manager.h
@@ -19,8 +19,8 @@ namespace gpu {
namespace gles2 {
class BufferManager;
+class ErrorState;
class FeatureInfo;
-class GLES2Decoder;
// Info about Buffers currently in the system.
class GPU_EXPORT Buffer : public base::RefCounted<Buffer> {
@@ -194,7 +194,7 @@ class GPU_EXPORT BufferManager {
// Does a glBufferData and updates the approprate accounting. Currently
// assume the values have already been validated.
void DoBufferData(
- GLES2Decoder* decoder,
+ ErrorState* error_state,
Buffer* buffer,
GLsizeiptr size,
GLenum usage,
@@ -202,7 +202,7 @@ class GPU_EXPORT BufferManager {
// Does a glBufferSubData and updates the approrate accounting.
void DoBufferSubData(
- GLES2Decoder* decoder,
+ ErrorState* error_state,
Buffer* buffer,
GLintptr offset,
GLsizeiptr size,
« no previous file with comments | « gpu/command_buffer/build_gles2_cmd_buffer.py ('k') | gpu/command_buffer/service/buffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698