Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 14308013: Try to close idle sockets in higher level pools when a pool is stalled. (Closed)

Created:
7 years, 8 months ago by mmenke
Modified:
7 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, willchan no longer on Chromium
Visibility:
Public.

Description

When a new request comes in to a socket pool, and that request's group is stalled due to the pool hitting the connection limit, try to close idle sockets in higher level pools. CLs to do this have been landed and reverted in the past, due to crashes. This CL attempts to avoid such crashes by reducing re-entracy. Idle sockets are closed asynchronously, and the CL relies on that automatically triggering use of the freed up socket slot. BUG=92244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195540

Patch Set 1 #

Patch Set 2 : Remove extra stuff #

Patch Set 3 : Rename method #

Patch Set 4 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -0 lines) Patch
M net/socket/client_socket_pool_base.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 1 2 3 2 chunks +20 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 1 chunk +284 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mmenke
[willchan]: FYI. [rch]: Added a bit more information on my current understanding about re-entrancy issues ...
7 years, 8 months ago (2013-04-17 16:47:17 UTC) #1
Ryan Hamilton
lgtm. I think this seems reasonable, but as I understand the issue, it's commonly SPDY ...
7 years, 8 months ago (2013-04-18 00:34:23 UTC) #2
mattmenke_gmail.com
On 2013/04/18 00:34:23, Ryan Hamilton wrote: > lgtm. > > I think this seems reasonable, ...
7 years, 8 months ago (2013-04-18 02:29:46 UTC) #3
willchan no longer on Chromium
Sorry, I meant to look at it but I don't really have time. Go ahead ...
7 years, 8 months ago (2013-04-18 22:17:41 UTC) #4
mmenke
No problem. There's a dev channel release going out on Sunday, and given the urgent ...
7 years, 8 months ago (2013-04-18 22:25:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/14308013/43001
7 years, 8 months ago (2013-04-22 14:30:13 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=105320
7 years, 8 months ago (2013-04-22 16:21:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/14308013/43001
7 years, 8 months ago (2013-04-22 16:22:53 UTC) #8
mmenke
7 years, 8 months ago (2013-04-22 17:32:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r195540 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698