Issue 14308012: Fixed missing CONNECTED state transition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14308012: Fixed missing CONNECTED state transition. (Closed)

Created:
7 years, 8 months ago by Jamie

Modified:
7 years, 8 months ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed missing CONNECTED state transition. Previously, the state stansition was CONNECTING->CONNECTED, but r194079 introduced the AUTHENTICATED state without updating the expectation in ConnectionToHost::NotifyIfChannelsReady BUG=231997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194488

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	remoting/protocol/connection_to_host.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jamie

7 years, 8 months ago (2013-04-16 23:50:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194488 (presubmit successful).

Expand Messages | Collapse Messages