editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java - Issue 14308011: New Analysis Engine snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java

Issue 14308011: New Analysis Engine snapshot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java ('k') | editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/JUnitSemanticProcessor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java

diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java

index dd3aa21ebcaade719736cab4b517be6e57ca61db..2e61bd54d5f26e0e7f8533d2dcc68ba91bb0962b 100644

--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java

+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java

@@ -45,7 +45,6 @@ import static com.google.dart.java2dart.util.ASTFactory.functionExpression;

import static com.google.dart.java2dart.util.ASTFactory.identifier;

import static com.google.dart.java2dart.util.ASTFactory.indexExpression;

import static com.google.dart.java2dart.util.ASTFactory.instanceCreationExpression;

-import static com.google.dart.java2dart.util.ASTFactory.integer;

import static com.google.dart.java2dart.util.ASTFactory.methodInvocation;

import static com.google.dart.java2dart.util.ASTFactory.propertyAccess;

import static com.google.dart.java2dart.util.ASTFactory.typeName;

@@ -115,7 +114,7 @@ public class CollectionSemanticProcessor extends SemanticProcessor {

&& JavaUtils.getQualifiedName(intfs[0]).equals("java.util.Comparator")) {

ClassDeclaration innerClass = context.getAnonymousDeclaration(node);

if (innerClass != null) {

- unit.getDeclarations().remove(innerClass);

+ boolean removed = unit.getDeclarations().remove(innerClass);

List<ClassMember> innerMembers = innerClass.getMembers();

MethodDeclaration compareMethod = (MethodDeclaration) innerMembers.get(0);

FunctionExpression functionExpression = functionExpression(

@@ -211,8 +210,7 @@ public class CollectionSemanticProcessor extends SemanticProcessor {

return null;

}

if (isMethodInClass2(node, "add(int,java.lang.Object)", "java.util.List")) {

- nameNode.setToken(TokenFactory.token("insertRange"));

- args.add(1, integer(1));

+ nameNode.setToken(TokenFactory.token("insert"));

return null;

}

if (isMethodInClass(node, "add", "java.util.Set")) {