Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 14308007: [NaCl] Don't cache font size (Closed)

Created:
7 years, 8 months ago by Sam Clegg
Modified:
7 years, 8 months ago
Reviewers:
noelallen1, binji
Base URL:
https://github.com/sbc100/cocos2d-x.git@nacl_changes2
Visibility:
Public.

Description

[NaCl] Don't cache font size This avoids churn of the cached font when different sizes of the same font are requested sequentially. Committed: https://github.com/samclegg/cocos2d-x/commit/0645ead

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M cocos2dx/platform/nacl/CCImage.cpp View 5 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
7 years, 8 months ago (2013-04-17 19:43:58 UTC) #1
binji
lgtm So the font size didn't need to be cached before...?
7 years, 8 months ago (2013-04-17 19:49:28 UTC) #2
Sam Clegg
7 years, 8 months ago (2013-04-18 18:19:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r0645ead (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698