win: Handle binary with embedded CodeView debug record

snapshot/win/module_snapshot_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 42 matching lines @@
                                     process_reader_module.size,
                                     base::UTF16ToUTF8(name_))) {
     return false;
   }
 
   DWORD age_dword;
   if (pe_image_reader_->DebugDirectoryInformation(
           &uuid_, &age_dword, &pdb_name_)) {
     static_assert(sizeof(DWORD) == sizeof(uint32_t), "unexpected age size");
     age_ = age_dword;
+  } else {
+    pdb_name_ = base::UTF16ToUTF8(name_);

[Mark Mentovai, 2015/10/30 19:42:44]

Add a short comment saying that this isn’t how the MS tools deal with this
situation.

I think what you’ve done here is totally reasonable.

[scottmg, 2015/10/30 23:52:07]

Done.

   }
 
   INITIALIZATION_STATE_SET_VALID(initialized_);
   return true;
 }
 
 void ModuleSnapshotWin::GetCrashpadOptions(CrashpadInfoClientOptions* options) {
   INITIALIZATION_STATE_DCHECK_VALID(initialized_);
   if (process_reader_->Is64Bit())
     GetCrashpadOptionsInternal<process_types::internal::Traits64>(options);
@@ skipping 114 matching lines @@
       CrashpadInfoClientOptions::TriStateFromCrashpadInfo(
           crashpad_info.crashpad_handler_behavior);
 
   options->system_crash_reporter_forwarding =
       CrashpadInfoClientOptions::TriStateFromCrashpadInfo(
           crashpad_info.system_crash_reporter_forwarding);
 }
 
 }  // namespace internal
 }  // namespace crashpad