win: Handle binary with embedded CodeView debug record

handler/win/crashy_test_z7_loader.cc

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include <windows.h>
+
+#include "base/logging.h"
+#include "client/crashpad_client.h"
+#include "tools/tool_support.h"
+
+#if !ARCH_CPU_32_BITS

[Mark Mentovai, 2015/10/30 19:42:44]

Should be !defined(ARCH_CPU_32_BITS). Found the same thing going on in
process_info.cc.

Since you want 32-bit x86 specifically, you can also use the more-specific
!defined(ARCH_CPU_X86).

[scottmg, 2015/10/30 23:52:07]

Done.

+#error This test is only supported on x86.
+#endif  // !ARCH_CPU_32_BITS
+
+namespace crashpad {
+namespace {
+
+int CrashyLoadZ7Main(int argc, char* argv[]) {
+  if (argc != 2) {
+    fprintf(stderr, "Usage: %s <server_pipe_name>\n", argv[0]);
+    return 1;

[Mark Mentovai, 2015/10/30 19:42:44]

<stdlib.h> EXIT_FAILURE, EXIT_SUCCESS

[scottmg, 2015/10/30 23:52:07]

Done.

+  }
+
+  CrashpadClient client;
+  if (!client.SetHandler(argv[1])) {
+    LOG(ERROR) << "SetHandler";
+    return 1;
+  }
+  if (!client.UseHandler()) {
+    LOG(ERROR) << "UseHandler";
+    return 1;
+  }
+
+  // The DLL has /Z7 symbols embedded in the binary (rather than in a .pdb).
+  // There's only an x86 version of this dll as newer x64 toolchains can't
+  // generate this format any more.
+  HMODULE z7_test = LoadLibrary(L"../../handler/win/z7_test.dll");

[Mark Mentovai, 2015/10/30 19:42:44]

If either of these fail, LOG(ERROR) and return EXIT_FAILURE. Wouldn’t want a
failure here to skew the test results because crash_me wound up as nullptr
because of a failure and crashed for an unrelated reason without the library
being loaded.

[Mark Mentovai, 2015/10/30 19:42:44]

This will be treated as a path relative to cwd, which is no good. Since
z7_test.dll is checked-in test data, build a path relative to test/paths.h’s
test::TestDataRoot().

[scottmg, 2015/10/30 23:52:07]

Done.

[scottmg, 2015/10/30 23:52:07]

Windows is very promiscuous and eventually tries relative the current module
too! But being explicit about that is probably better.

[Mark Mentovai, 2015/10/31 01:29:33]

scottmg wrote:
Ha!

+  FARPROC crash_me = GetProcAddress(z7_test, "?CrashMe@@YAXXZ");
+  reinterpret_cast<void(*)()>(crash_me)();
+
+  return 0;
+}
+
+}  // namespace
+}  // namespace crashpad
+
+int wmain(int argc, wchar_t* argv[]) {
+  return crashpad::ToolSupport::Wmain(argc, argv, crashpad::CrashyLoadZ7Main);
+}
+

[Mark Mentovai, 2015/10/30 19:42:44]

Remove the blank line at EOF.

[scottmg, 2015/10/30 23:52:07]

Done.