Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1430763002: Remove shared_handles.{cc,h} (Closed)

Created:
5 years, 1 month ago by rickyz (no longer on Chrome)
Modified:
5 years, 1 month ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove shared_handles.{cc,h} As far as I can tell, these have unused for at least the last 3 years. Committed: https://crrev.com/fda4a850b8c1452563f78033d537a7f53220981c Cr-Commit-Position: refs/heads/master@{#357149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -179 lines) Patch
M sandbox/win/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/win/sandbox_win.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D sandbox/win/src/shared_handles.h View 1 chunk +0 lines, -108 lines 0 comments Download
D sandbox/win/src/shared_handles.cc View 1 chunk +0 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rickyz (no longer on Chrome)
5 years, 1 month ago (2015-10-29 22:28:44 UTC) #2
Will Harris
lgtm
5 years, 1 month ago (2015-10-30 17:23:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430763002/1
5 years, 1 month ago (2015-10-30 18:09:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 18:43:17 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:44:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fda4a850b8c1452563f78033d537a7f53220981c
Cr-Commit-Position: refs/heads/master@{#357149}

Powered by Google App Engine
This is Rietveld 408576698