Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1430753002: DevTools: [CodeMirror] highlight Stylus files (Closed)

Created:
5 years, 1 month ago by lushnikov
Modified:
5 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [CodeMirror] highlight Stylus files The patch adds Stylus mode to the "lazy" cm-modes. This means the mode will not be bundled with chrome; instead, it will be loaded from the cloud if client needs it. BUG=428657 R=dgozman@chromium.org, dgozman, pfeldman NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/f04b9a5c8e0aa7e59ff41b9c17e3203844c225a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+783 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/cm_modes/module.json View 2 chunks +10 lines, -1 line 0 comments Download
A third_party/WebKit/Source/devtools/front_end/cm_modes/stylus.js View 1 chunk +769 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ResourceType.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
lushnikov
ptal
5 years, 1 month ago (2015-10-29 22:09:44 UTC) #1
dgozman
Did you check the license? patch lgtm
5 years, 1 month ago (2015-10-29 22:26:54 UTC) #2
lushnikov
The license is MIT
5 years, 1 month ago (2015-10-29 23:36:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430753002/1
5 years, 1 month ago (2015-10-29 23:38:12 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114137)
5 years, 1 month ago (2015-10-29 23:56:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430753002/1
5 years, 1 month ago (2015-10-30 00:10:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/114153)
5 years, 1 month ago (2015-10-30 00:20:46 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f04b9a5c8e0aa7e59ff41b9c17e3203844c225a4 Cr-Commit-Position: refs/heads/master@{#357015}
5 years, 1 month ago (2015-10-30 01:46:20 UTC) #13
lushnikov
5 years, 1 month ago (2015-10-30 01:46:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f04b9a5c8e0aa7e59ff41b9c17e3203844c225a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698