Minor cleanup of SetQuicServerInfo.

Minor cleanup of SetQuicServerInfo.

R=wtc@chromium.org, rvargas@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247095

[rvargas (doing something else), 2014-01-23 19:36:44]

LGTM, thanks.

[wtc, 2014-01-23 23:25:24]

Patch set 2 LGTM.

https://codereview.chromium.org/143073006/diff/40001/net/http/http_transactio...
File net/http/http_transaction_unittest.h (right):

https://codereview.chromium.org/143073006/diff/40001/net/http/http_transactio...
net/http/http_transaction_unittest.h:27: #include
"net/quic/crypto/quic_server_info.h"

A forward declaration of QuicServerInfo should suffice.

[ramant (doing other things), 2014-01-23 23:57:13]

https://codereview.chromium.org/143073006/diff/40001/net/http/http_transactio...
File net/http/http_transaction_unittest.h (right):

https://codereview.chromium.org/143073006/diff/40001/net/http/http_transactio...
net/http/http_transaction_unittest.h:27: #include
"net/quic/crypto/quic_server_info.h"
On 2014/01/23 23:25:24, wtc wrote:
> 
> A forward declaration of QuicServerInfo should suffice.

Done.

[wtc, 2014-01-24 02:29:59]

Patch set 3 LGTM.

https://codereview.chromium.org/143073006/diff/110001/net/http/http_transacti...
File net/http/http_transaction_unittest.h (right):

https://codereview.chromium.org/143073006/diff/110001/net/http/http_transacti...
net/http/http_transaction_unittest.h:31: class QuicServerInfo;

We may not even need the forward declaration. It's already in the header
http_transaction.h for the base class.

[ramant (doing other things), 2014-01-24 22:19:13]

https://codereview.chromium.org/143073006/diff/110001/net/http/http_transacti...
File net/http/http_transaction_unittest.h (right):

https://codereview.chromium.org/143073006/diff/110001/net/http/http_transacti...
net/http/http_transaction_unittest.h:31: class QuicServerInfo;
On 2014/01/24 02:30:00, wtc wrote:
> 
> We may not even need the forward declaration. It's already in the header
> http_transaction.h for the base class.

Done.

[wtc, 2014-01-24 22:50:17]

Patch set 4 LGTM.

https://codereview.chromium.org/143073006/diff/160001/net/http/http_cache_tra...
File net/http/http_cache_transaction.h (right):

https://codereview.chromium.org/143073006/diff/160001/net/http/http_cache_tra...
net/http/http_cache_transaction.h:129: virtual void
SetQuicServerInfo(QuicServerInfo* quic_server_info) OVERRIDE {};

Should we define this method in the .cc file, like the other methods?

https://codereview.chromium.org/143073006/diff/160001/net/http/http_network_t...
File net/http/http_network_transaction.h (right):

https://codereview.chromium.org/143073006/diff/160001/net/http/http_network_t...
net/http/http_network_transaction.h:70: virtual void
SetQuicServerInfo(QuicServerInfo* quic_server_info) OVERRIDE {};

Should we define this method in the .cc file, like the other methods?

https://codereview.chromium.org/143073006/diff/160001/net/http/http_transacti...
File net/http/http_transaction_unittest.h (right):

https://codereview.chromium.org/143073006/diff/160001/net/http/http_transacti...
net/http/http_transaction_unittest.h:207: net::QuicServerInfo* quic_server_info)
OVERRIDE {}

Should we define this method in the .cc file, like the other methods?

[ramant (doing other things), 2014-01-24 23:26:06]

PTAL.

https://codereview.chromium.org/143073006/diff/160001/net/http/http_cache_tra...
File net/http/http_cache_transaction.h (right):

https://codereview.chromium.org/143073006/diff/160001/net/http/http_cache_tra...
net/http/http_cache_transaction.h:129: virtual void
SetQuicServerInfo(QuicServerInfo* quic_server_info) OVERRIDE {};
On 2014/01/24 22:50:17, wtc wrote:
> 
> Should we define this method in the .cc file, like the other methods?

Done.

https://codereview.chromium.org/143073006/diff/160001/net/http/http_network_t...
File net/http/http_network_transaction.h (right):

https://codereview.chromium.org/143073006/diff/160001/net/http/http_network_t...
net/http/http_network_transaction.h:70: virtual void
SetQuicServerInfo(QuicServerInfo* quic_server_info) OVERRIDE {};
On 2014/01/24 22:50:17, wtc wrote:
> 
> Should we define this method in the .cc file, like the other methods?

Changed other methods too.

https://codereview.chromium.org/143073006/diff/160001/net/http/http_transacti...
File net/http/http_transaction_unittest.h (right):

https://codereview.chromium.org/143073006/diff/160001/net/http/http_transacti...
net/http/http_transaction_unittest.h:207: net::QuicServerInfo* quic_server_info)
OVERRIDE {}
On 2014/01/24 22:50:17, wtc wrote:
> 
> Should we define this method in the .cc file, like the other methods?

Done.

[wtc, 2014-01-25 01:19:00]

Patch set 5 LGTM.

[commit-bot: I haz the power, 2014-01-25 01:24:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/143073006/250001

[commit-bot: I haz the power, 2014-01-25 07:50:15]

Change committed as 247095