Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1430723002: Refactor code for checking that generated files are up to date. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor code for checking that generated files are up to date. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cebb0dfb9133d58be11065226f373602677e608e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M pkg/analyzer/lib/src/codegen/tools.dart View 1 chunk +47 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/check_test.dart View 2 chunks +3 lines, -15 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-10-29 20:55:40 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-10-29 21:59:01 UTC) #3
Paul Berry
5 years, 1 month ago (2015-11-02 18:46:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cebb0dfb9133d58be11065226f373602677e608e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698