Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: runtime/vm/object.h

Issue 14307013: - Remember the fact that an object has been added to the (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 22392)
+++ runtime/vm/object.h (working copy)
@@ -440,9 +440,10 @@
*addr = value;
// Filter stores based on source and target.
if (!value->IsHeapObject()) return;
- if (value->IsNewObject() && raw()->IsOldObject()) {
- uword ptr = reinterpret_cast<uword>(raw());
- Isolate::Current()->store_buffer()->AddPointer(ptr);
+ if (value->IsNewObject() && raw()->IsOldObject() &&
+ !raw()->IsRemembered()) {
+ raw()->SetRememberedBit();
+ Isolate::Current()->store_buffer()->AddObject(raw());
}
}
@@ -4973,9 +4974,10 @@
*addr = value;
// Filter stores based on source and target.
if (!value->IsHeapObject()) return;
- if (value->IsNewObject() && data()->IsOldObject()) {
- uword ptr = reinterpret_cast<uword>(data());
- Isolate::Current()->store_buffer()->AddPointer(ptr);
+ if (value->IsNewObject() && data()->IsOldObject() &&
+ !data()->IsRemembered()) {
+ data()->SetRememberedBit();
+ Isolate::Current()->store_buffer()->AddObject(data());
}
}
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698