webkit: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

webkit: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details.

BUG=234765
R=jamesr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197204

[jamesr, 2013-04-26 20:58:10]

lgtm

[commit-bot: I haz the power, 2013-04-26 21:06:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/14307012/2001

[commit-bot: I haz the power, 2013-04-27 01:09:38]

Failed to apply patch for webkit/plugins/ppapi/ppb_graphics_2d_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  |diff --git a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  |index
590a61d2d943a020a37aa64c9831649a845ab4b4..6b7aaa5d15063395c4d5204da01661900a299e4b
100644
  |--- a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  |+++ b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
Index: webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
index
590a61d2d943a020a37aa64c9831649a845ab4b4..6b7aaa5d15063395c4d5204da01661900a299e4b
100644
--- a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
+++ b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
@@ -168,7 +168,7 @@ PPB_Graphics2D_Impl::PPB_Graphics2D_Impl(PP_Instance
instance)
       offscreen_flush_pending_(false),
       is_always_opaque_(false),
       scale_(1.0f),
-      weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
+      weak_ptr_factory_(this) {
 }
 
 PPB_Graphics2D_Impl::~PPB_Graphics2D_Impl() {

[commit-bot: I haz the power, 2013-04-27 01:37:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/14307012/2001

[commit-bot: I haz the power, 2013-04-27 01:38:05]

Failed to apply patch for webkit/plugins/ppapi/ppb_graphics_2d_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  |diff --git a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  |index
590a61d2d943a020a37aa64c9831649a845ab4b4..6b7aaa5d15063395c4d5204da01661900a299e4b
100644
  |--- a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  |+++ b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
Index: webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
index
590a61d2d943a020a37aa64c9831649a845ab4b4..6b7aaa5d15063395c4d5204da01661900a299e4b
100644
--- a/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
+++ b/webkit/plugins/ppapi/ppb_graphics_2d_impl.cc
@@ -168,7 +168,7 @@ PPB_Graphics2D_Impl::PPB_Graphics2D_Impl(PP_Instance
instance)
       offscreen_flush_pending_(false),
       is_always_opaque_(false),
       scale_(1.0f),
-      weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
+      weak_ptr_factory_(this) {
 }
 
 PPB_Graphics2D_Impl::~PPB_Graphics2D_Impl() {

[scherkus (not reviewing), 2013-04-30 01:05:52]

Committed patchset #2 manually as r197204 (presubmit successful).