Issue 14307011: ppapi: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14307011: ppapi: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST. (Closed)

Created:
7 years, 8 months ago by scherkus (not reviewing)

Modified:
7 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ppapi: Remove use of ALLOW_THIS_IN_INITIALIZER_LIST. It's no longer providing value as the MSVC warning is disabled during compilation. Refer to bug for details. NOTE: This doesn't address PP_ALLOW_THIS_IN_INITIALIZER_LIST. BUG=234765 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197205

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	ppapi/proxy/audio_input_resource.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/device_enumeration_resource_helper_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_broker_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_file_ref_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_graphics_3d_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_instance_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_url_loader_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_var_deprecated_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_video_decoder_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/video_capture_resource.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/shared_impl/resource_tracker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scherkus (not reviewing)

7 years, 7 months ago (2013-04-30 01:06:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r197205 (presubmit successful).