Issue 14307006: Make it possible to Crankshaft all kinds of stubs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14307006: Make it possible to Crankshaft all kinds of stubs. (Closed)

Created:
7 years, 8 months ago by danno

Modified:
7 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make it possible to Crankshaft all kinds of stubs. Committed: http://code.google.com/p/v8/source/detail?r=14323

Patch Set 1 #

Patch Set 2 : Review feedback #

Patch Set 3 : Review feedback #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -63 lines)			Patch
M	src/arm/code-stubs-arm.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.h	View		9 chunks	+15 lines, -15 lines	0 comments	Download
M	src/code-stubs.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/codegen.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/compiler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/deoptimizer.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/disassembler.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/factory.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/factory.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/heap.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lithium.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lithium.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/log.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1	4 chunks	+18 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1	6 chunks	+17 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/safepoint-table.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/spaces.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM. But isn't "is_compiled" a bit misleading? Code of kind FUNCTION are, technically speaking, also ...

7 years, 8 months ago (2013-04-18 08:58:25 UTC) #2

danno

7 years, 8 months ago (2013-04-18 09:51:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r14323 (presubmit successful).

Expand Messages | Collapse Messages