Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1430673002: Headless demo (Closed)

Created:
5 years, 1 month ago by altimin
Modified:
3 years, 7 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Headless demo Dumps dom into dom.json file. Saves screenshot into screenshot.png file.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Headless demo 2.0: app/ and lib/ separated #

Patch Set 3 : Headless demo 2.1: fixed bounding box and param handling #

Patch Set 4 : Now browser shuts down after loading page. #

Patch Set 5 : Image capturing (TODO: restore thread check in FileWrite) #

Patch Set 6 : Tracing #

Patch Set 7 : Rebased #

Patch Set 8 : Remote devtools #

Patch Set 9 : Fixed the main #

Patch Set 10 : Callback for javascript value #

Patch Set 11 : Removed content/shell from all deps #

Patch Set 12 : Shiny new version #

Patch Set 13 : Better javascript #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2590 lines, -114 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/ui.gni View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A headless/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +79 lines, -0 lines 0 comments Download
A + headless/DEPS View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -4 lines 0 comments Download
A headless/app/headless_shell.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +267 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_browser_context.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +92 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_browser_context.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +173 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_browser_main_parts.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +37 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_browser_main_parts.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +50 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +36 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +40 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_devtools.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +25 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_devtools.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +141 lines, -0 lines 0 comments Download
A + headless/lib/browser/headless_network_delegate.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -10 lines 0 comments Download
A + headless/lib/browser/headless_network_delegate.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +21 lines, -21 lines 0 comments Download
A + headless/lib/browser/headless_url_request_context_getter.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +14 lines, -14 lines 0 comments Download
A + headless/lib/browser/headless_url_request_context_getter.cc View 1 2 3 4 5 6 7 8 9 10 12 chunks +28 lines, -60 lines 0 comments Download
A headless/lib/headless_browser_impl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +71 lines, -0 lines 0 comments Download
A headless/lib/headless_browser_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +214 lines, -0 lines 0 comments Download
A headless/lib/headless_content_client.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +29 lines, -0 lines 0 comments Download
A headless/lib/headless_content_client.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +39 lines, -0 lines 0 comments Download
A headless/lib/headless_shell_main_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +60 lines, -0 lines 0 comments Download
A headless/lib/headless_shell_main_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +125 lines, -0 lines 0 comments Download
A headless/lib/renderer/headless_content_renderer_client.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
A headless/lib/renderer/headless_content_renderer_client.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +13 lines, -0 lines 0 comments Download
A headless/lib/utility/headless_content_utility_client.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
A headless/lib/utility/headless_content_utility_client.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +13 lines, -0 lines 0 comments Download
A headless/lib/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +55 lines, -0 lines 0 comments Download
A headless/lib/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +124 lines, -0 lines 0 comments Download
A headless/lib/web_document.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +22 lines, -0 lines 0 comments Download
A headless/lib/web_element.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +48 lines, -0 lines 0 comments Download
A headless/lib/web_frame_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +52 lines, -0 lines 0 comments Download
A headless/lib/web_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +134 lines, -0 lines 0 comments Download
A headless/lib/web_node.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +68 lines, -0 lines 0 comments Download
A headless/public/headless_browser.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +113 lines, -0 lines 0 comments Download
A headless/public/headless_browser.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +48 lines, -0 lines 0 comments Download
A headless/public/headless_export.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +29 lines, -0 lines 0 comments Download
A headless/public/network.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +29 lines, -0 lines 0 comments Download
A headless/public/web_contents.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +61 lines, -0 lines 0 comments Download
A headless/public/web_document.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +28 lines, -0 lines 0 comments Download
A headless/public/web_element.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +44 lines, -0 lines 0 comments Download
A headless/public/web_frame.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +50 lines, -0 lines 0 comments Download
A headless/public/web_node.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +51 lines, -0 lines 0 comments Download
M tools/vim/chromium.ycm_extra_conf.py View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
altimin
5 years, 1 month ago (2015-10-28 18:44:06 UTC) #3
Sami
5 years, 1 month ago (2015-10-30 11:12:18 UTC) #4 
https://codereview.chromium.org/1430673002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebNode.h (right):

https://codereview.chromium.org/1430673002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebNode.h:107: BLINK_EXPORT ExportedBoundingBox
boundingBox() const;
I think we can just use WebElement::boundsInViewportSpace() for this:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Powered by Google App Engine
This is Rietveld 408576698