Issue 1430643003: Inline single test-only call of Scope::LookupThis method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1430643003: Inline single test-only call of Scope::LookupThis method (Closed)

Created:
5 years, 1 month ago by adamk

Modified:
5 years, 1 month ago

Reviewers:
Dan Ehrenberg

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Inline single test-only call of Scope::LookupThis method R=littledan@chromium.org Committed: https://crrev.com/40f43c91a59835819cdd544b25d0ea415a753bbb Cr-Commit-Position: refs/heads/master@{#31644}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/scopes.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	test/cctest/test-parsing.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430643003/1

5 years, 1 month ago (2015-10-29 06:21:58 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-10-29 06:40:01 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/40f43c91a59835819cdd544b25d0ea415a753bbb
Cr-Commit-Position: refs/heads/master@{#31644}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages